Array version of step function - #37
Merged
Merged
Conversation
Collaborator
Author
|
Undid the change to scale_wrapper so that the pull request would pass the github test. So scale_step will only really be called with two amplitudes. But it's written in array form anyway so when we want to set up scale_wrapper for more than 2 amplitudes, for e.g. the DIII-D bolometers, the scale_step function is ready. |
jherf
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step function (and scale_wrapper generally) now written with amplitude and scale parameters as a combined array.
Note that "_post_process_calculations" in Emis3D.py still assumes only two scale parameters, so if we want to use the step function on a device other than JET with more than 2 relevant scale parameters for a step function, that would probably need to be changed.