Skip to content

Conversation

@pelesh
Copy link
Collaborator

@pelesh pelesh commented Dec 17, 2025

Description

Remove style guidelines for enums because we are already making exceptions for enums entering the JSON parser.

@superwhiskers

Proposed changes

For now, just remove style guidelines for enums.

Checklist

N/A

@pelesh pelesh requested a review from PhilipFackler December 17, 2025 19:13
@PhilipFackler
Copy link
Collaborator

I'm surprised you're removing the guideline altogether. I would think we would want enum value formatting to be consistent across the project, even if the style should be different from what this section says.

@pelesh
Copy link
Collaborator Author

pelesh commented Dec 18, 2025

I'm surprised you're removing the guideline altogether. I would think we would want enum value formatting to be consistent across the project, even if the style should be different from what this section says.

Updated guidelines for enums.

@pelesh pelesh self-assigned this Dec 18, 2025
@pelesh pelesh added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 18, 2025
@PhilipFackler PhilipFackler merged commit 7d2bcd1 into PhilipFackler/print-monitored-vars Dec 19, 2025
6 checks passed
PhilipFackler pushed a commit that referenced this pull request Dec 19, 2025
* Update CONTRIBUTING.md

* Add specific guidelines for enums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants