g.remove: migrate tests from gunittest to pytest - #7896
Draft
Valyrian-Code wants to merge 1 commit into
Draft
Conversation
Member
Good :) |
github-actions
Bot
added
Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the g.remove testsuite from gunittest to pytest, continuing the one-at-a-time migrations from #7635/#7675/#7780/#7893/#7894.
Same three cases as before: the dry-run listing versus -f actually removing and logging each removal to stderr, the exclude= option, and the -r/-e mutual exclusivity check.
One small change on that last one: the old test just checked that "-r" and "-e" both appear somewhere in the error output, which is true even for an unrelated error, since the full usage text always lists both flags. This checks the specific "mutually exclusive" message instead.
Verified locally, all three pass.