Skip to content

CI: Enable XML in codespell and fix typos- #685 - #7900

Open
echoix wants to merge 2 commits into
OSGeo:mainfrom
echoix:fix/xml-codespell-typos
Open

CI: Enable XML in codespell and fix typos- #685#7900
echoix wants to merge 2 commits into
OSGeo:mainfrom
echoix:fix/xml-codespell-typos

Conversation

@echoix

@echoix echoix commented Sep 5, 2026

Copy link
Copy Markdown
Member

Summary

Enables XML file type in codespell, fixes typos found in XML files, and skips SVG files (which codespell/identify treats as XML) to avoid false positives from embedded base64 image data.

Changes

  • Enable XML in codespell: Removed xml from exclude_types in .pre-commit-config.yaml.
  • Fix typos: Corrected "co-ordinate" to "coordinate" in:
    • gui/wxpython/xml/wxgui_items.xml (1 occurrence)
    • gui/wxpython/core/testsuite/data/test_toolboxes_menudata_ref.xml (2 occurrences)
  • Skip SVG files: Added *.svg to codespell's skip list in pyproject.toml. SVG is tagged as an XML type by identify, so enabling XML also unexcluded SVG; gui/images/splash_screen.svg embeds a base64 JPEG that codespell misread as typos (e.g. "nd", "Ot", "tHt"), which failed CI.

Testing

  • pre-commit run codespell --all-files passes locally.

echoix and others added 2 commits September 5, 2026 17:19
Enable XML file type in codespell by removing it from exclude_types
in .pre-commit-config.yaml. Fix all typos found in XML files:
- gui/wxpython/xml/wxgui_items.xml: coordinate (1 occurrence)
- gui/wxpython/core/testsuite/data/test_toolboxes_menudata_ref.xml: coordinate (2 occurrences)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Enabling codespell for XML also covers SVG (identify tags it as an
XML type). gui/images/splash_screen.svg embeds a base64-encoded JPEG
that codespell misreads as misspelled words (e.g. "nd", "Ot", "tHt").
Skip *.svg via codespell's own skip list so the exclusion also
applies when codespell is run directly, not just through pre-commit.
@echoix
echoix enabled auto-merge (squash) September 5, 2026 22:20
@echoix
echoix disabled auto-merge September 5, 2026 22:20
@echoix
echoix enabled auto-merge (squash) September 5, 2026 22:20
@github-actions github-actions Bot added GUI wxGUI related CI Continuous integration Python Related code is in Python tests Related to Test Suite labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration GUI wxGUI related Python Related code is in Python tests Related to Test Suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants