Task: add remote prop to SuggestInput. #48
Open
josephlouise74 wants to merge 12 commits intoOSSPhilippines:mainfrom
Open
Task: add remote prop to SuggestInput. #48josephlouise74 wants to merge 12 commits intoOSSPhilippines:mainfrom
josephlouise74 wants to merge 12 commits intoOSSPhilippines:mainfrom
Conversation
…g url like http://example.com/suggest and this url should return an array of strings used to update the options.
…g url like http://example.com/suggest and this url should return an array of strings used to update the options.
…g url like http://example.com/suggest and this url should return an array of strings used to update the options.
Pull Request Test Coverage Report for Build 20804631473Details
💛 - Coveralls |
cblanquera
requested changes
Jan 6, 2026
Collaborator
cblanquera
left a comment
There was a problem hiding this comment.
Missing test and documentation update for this task. Also you need to add a fetch prop to allow dependency injection mainly for tests. Consider the following code.
const {
//...
fetch: customFetch = fetch
//...
} = props;
cblanquera
requested changes
Jan 7, 2026
and add comment handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Summary
Added a new
remoteprop to theSuggestInputcomponent.This prop accepts a string URL (e.g.
http://example.com/suggest) that returns an array of strings, which is then used to dynamically update the suggestion options.This enhancement allows
SuggestInputto fetch suggestions from a remote source, improving flexibility and usability for dynamic data scenarios.I verify that...
npm run testwith no errors