Replace obsolete Boost seed-invariance test - #122
Closed
OVVO-Financial wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NNS.stackestimates.Description
tests/parity/test_boost.pyto replace the obsoletetest_nns_boost_ivs_test_none_is_seed_invariantwith a parametrized same-seed reproducibility testtest_nns_boost_ivs_test_none_is_seed_reproduciblethat matches the requested implementation and asserts identical results when reusing arandom_seed.tests/parity/test_boost.pyto note that the default seed123is used to match RNNS.boostand its delegatedNNS.stackfolds.conftest.pycollection hook are not used (the branch contains only the direct edit to the original Boost parity test).src/nns/boost.py,src/nns/stack.py) or configuration files listed as off-limits.Testing
python -m ruff check . --fixandpython -m ruff check ., and both completed with no remaining Ruff violations.NNS_R_CACHE_ONLY=1 python -m pytest -q tests/parity,python -m pytest -q tests/invariants, andpython -m pytest -q tests/property, but these runs failed locally due to missing runtime test dependencies (ModuleNotFoundError: No module named 'numpy').python -m mypyandpython -m build, which could not complete in this environment due to missing build/runtime dependencies and toolchain components (NumPy/matplotlib stubs and thebuildpackage).Codex Task