Remove downstream nowcasting feature (1.0.2) - #26
Merged
Conversation
NNS R deprecated nowcasting, so drop the Python nowcast panel/provider feature. Keep the no-op nowcast= signature arg on nns_var (R NNS.VAR parity). Removed: - src/nns/nowcast.py (nns_nowcast_panel) and the nns.providers package (CsvNowcastProvider) - the nns_nowcast_panel public export - tests/invariants/test_nowcast.py, the nowcast example and notebook - nowcast rows/sections from README, docs/api_status.md, docs/conventions.md, and docs/examples/README.md test_export_surface.py now guards that nns_nowcast / nns_nowcast_panel are not public and that nns.nowcast / nns.providers are gone. The vendored R snapshot under tools/NNS is left untouched (provenance-pinned 13.0 reference). Bumped to 1.0.2 since 1.0.0/1.0.1 are already on PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NNS R deprecated nowcasting, so this removes the Python nowcast panel/provider feature. The no-op
nowcast=signature arg onnns_varis kept (RNNS.VARparity), per request.Removed
src/nns/nowcast.py(nns_nowcast_panel) and thenns.providerspackage (CsvNowcastProvider)nns_nowcast_panelpublic export fromnns.__all__tests/invariants/test_nowcast.py,docs/examples/nowcast_panel.py, and the03_forecasting_nowcast_workflow.ipynbnotebookREADME.md,docs/api_status.md,docs/conventions.md,docs/examples/README.mdKept / guarded
nns_var(..., nowcast=False)— unchanged signature pass-through.tests/invariants/test_export_surface.pynow assertsnns_nowcast/nns_nowcast_panelare not public and thatnns.nowcast/nns.providersno longer import — a regression guard so nowcast can't creep back.tools/NNS/**is intentionally untouched (provenance-pinned 13.0 reference; editing it would break the parity/provenance checks).Version
Bumped to
1.0.2(1.0.0 and 1.0.1 are already published on PyPI and immutable).Validation
import nns→1.0.2;nns_nowcast_panelgone;nns.nowcast/nns.providersModuleNotFoundError;nns_varstill hasnowcastparam. ruff + mypy (166 files) clean; export-surface/var/version-sync tests pass;twine check --strictpasses onovvo_nns-1.0.2.tar.gz; provenance gate passes forv1.0.2.https://claude.ai/code/session_012bjk4Y5eT1Sva8tNJjqUSw
Generated by Claude Code