Release 1.0.3: fix stale README version + enforce version consistency - #29
Merged
Merged
Conversation
The README 'Current version' row is hand-maintained and was left at 1.0.1 when 1.0.2 was cut, so the published 1.0.2 PyPI page (README is the project description) shows the wrong version. PyPI versions are immutable, so the fix ships as 1.0.3. - Bump pyproject, nns.__version__, and the README current-version row to 1.0.3. - Add scripts/check_version_consistency.py: fails if pyproject, nns.__version__, and the README current-version row disagree. - Run it as a release gate in release.yml (every release) so a stale version can never be published again, and assert it in tests/tools/test_version_sync.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the 1.0.3 fix after PR #28 squash-merged the wrong diff (it duplicated #27 at version 1.0.2 without the version-consistency changes).
What
pyproject,nns.__version__, and the README current-version row to 1.0.3 (fixes the stale1.0.1row that made the published 1.0.2 page show the wrong version).scripts/check_version_consistency.py— fails if pyproject,nns.__version__, and the README current-version row disagree.release.yml(every release) and assert it intests/tools/test_version_sync.py, so a stale version can never publish again.Validation
Consistency gate passes (and fails on tamper); ruff/version-sync test pass; provenance gate passes for
v1.0.3.https://claude.ai/code/session_012bjk4Y5eT1Sva8tNJjqUSw
Generated by Claude Code