Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changed_files.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[
"R/ARMA.R"
"R/Regression.R",
"src/nns_reg_points.cpp"
]
18 changes: 12 additions & 6 deletions sync/last_live_r_parity_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,18 @@
- Plan: `sync/last_r_api_plan.json`
- R checkout: `upstream/NNS`
- Fresh cache requested: `False`
- Skip install: `False`
- Live R recompute: `True`
- Skip install: `True`
- Live R recompute: `False`

## Result: live R parity diverged
## Result: mapped live R parity tests passed

Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit.
Tests run:

Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py`
Exit status: `1`
- `tests/parity/test_practical_examples.py`
- `tests/parity/test_r13_smoke.py`

## Workflow step outcome

- `run_live_r_parity_for_changed_api.py` step outcome: `success`
- Fresh cache requested: `false`
- DESCRIPTION changed: `false`
11 changes: 6 additions & 5 deletions sync/last_r_api_inspection.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

## Changed files

- `R/ARMA.R`
- `R/Regression.R`
- `src/nns_reg_points.cpp`

## Affected Python modules

- `src/nns/arma.py`
- `src/nns/multivariate_regression.py`
- `src/nns/regression.py`

## Parity tests to run

Expand All @@ -15,9 +17,8 @@

## Cache scope

- `NNS.ARMA`
- `NNS.ARMA.optim`
- `NNS.VAR`
- `NNS.M.reg`
- `NNS.reg`

## Required actions

Expand Down
11 changes: 6 additions & 5 deletions sync/last_r_api_plan.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
{
"changed_files": [
"R/ARMA.R"
"R/Regression.R",
"src/nns_reg_points.cpp"
],
"affected_python_modules": [
"src/nns/arma.py"
"src/nns/multivariate_regression.py",
"src/nns/regression.py"
],
"parity_tests": [
"tests/parity/test_practical_examples.py",
"tests/parity/test_r13_smoke.py"
],
"cache_scope": [
"NNS.ARMA",
"NNS.ARMA.optim",
"NNS.VAR"
"NNS.M.reg",
"NNS.reg"
],
"requires_fresh_cache": false,
"requires_export_review": false,
Expand Down
2 changes: 1 addition & 1 deletion upstream/NNS
Submodule NNS updated from 7250bb to a73b3b
Loading