Remove stray repo artifacts and slim the sdist - #73
Merged
Conversation
- Drop the orphaned upstream/NNS gitlink (no .gitmodules entry, empty on clone) and the committed workflow input changed_files.json; ignore the latter so sync runs cannot re-add it. - Delete original_tests/testthat/Rplots.pdf, a headless-R plotting dump. - Ignore /upstream/ checkouts and local notes. - Fix sdist contents: sdist.include is additive over all git-tracked files, so the 22 MB parity cache, vendored R tree, and R tarball were shipping in every sdist. Exclude maintainer-only paths instead, keeping build essentials plus sync/nns_source.json for provenance. 8.5 MB -> 159 KB, verified by installing the sdist into a fresh venv (native extension builds, smoke test passes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
upstream/NNSgitlink. It has no.gitmodulesentry, so fresh clones get a broken, permanently-empty submodule stub.changed_files.jsonfrom the repo root and gitignores it. It is a workflow input written byinspect-r-api-update;create-pull-request'sgit add -Aswept it into a sync PR once, which is how it got committed.original_tests/testthat/Rplots.pdf, a headless-R plotting dump./upstream/and the untracked local notes file.sdist.includeis additive over the git-tracked tree in scikit-build-core, so the previous list did nothing: the 22 MB parity cache, the vendored R tree, and the R tarball all shipped to everypip installfrom source. Switched tosdist.excludefor maintainer-only paths, keeping build essentials plussync/nns_source.jsonfor release provenance.sync/last_*reports stay tracked on purpose: the R API inspection workflow commits them as the fidelity record its PRs reference.Verification
nns.lpm(1, 0.0, [-1, 1, 2]) == 1/3.pytest tests/tools: 13 passed (manifest and version consistency checks).