Remove the unused nnscore() accessor - #76
Merged
Merged
Conversation
native_fn() has been the only dispatch seam since the native-dispatch
cleanup; nnscore() had no remaining callers anywhere in the repo. The
'is the native backend loaded' diagnostic is still available as
native_fn("lpm") is not None. The nnscore CMake target name for the
NNS-core C++ library is unrelated and unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #75.
native_fn()is now the only native-dispatch seam, leavingnnscore()with zero callers across src, tests, scripts, docs, and workflows (verified by repo-wide grep). Deleted.Notes:
nnscoreCMake target (extern/NNS-core's C++ library name) is unrelated build-system naming and is unchanged.nns._nativeis a private module, so no deprecation period is needed.