Skip to content

fix: return 400 when text param is missing in text_search #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiwani42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return 400 when text param is missing in text_search #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions application/tests/web_main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,12 @@ def test_test_search(self) -> None:
collection.add_node(docs["sa"])

with self.app.test_client() as client:
response = client.get("/rest/v1/text_search")
self.assertEqual(400, response.status_code)

response = client.get("/rest/v1/text_search?text=")
self.assertEqual(400, response.status_code)

response = client.get(f"/rest/v1/text_search?text='CRE:2'")
self.assertEqual(404, response.status_code)

Expand Down
2 changes: 2 additions & 0 deletions application/web/web_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,8 @@ def text_search() -> Any:
"""
database = db.Node_collection()
text = request.args.get("text")
if not text:
return jsonify({"error": "text parameter is required"}), 400
if posthog:
posthog.capture(f"text_search", f"text:{text}")

Expand Down