Skip to content

Add Storybook lockfile example and verified case study#474

Merged
sonukapoor merged 1 commit into
OWASP:mainfrom
Ayush7614:ayush4
May 30, 2026
Merged

Add Storybook lockfile example and verified case study#474
sonukapoor merged 1 commit into
OWASP:mainfrom
Ayush7614:ayush4

Conversation

@Ayush7614

@Ayush7614 Ayush7614 commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Closes #465

Summary

  • Adds examples/storybook/ with package.json and yarn.lock pinned to storybookjs/storybook@cc19ae1
  • Adds website/docs/case-studies/storybook.md with verified baseline scan results (CVE Lite CLI v1.18.0)
  • Documents comparison with default yarn npm audit on the same lockfile (3 entries vs 92 unique CVE Lite findings across 3,008 packages)
  • Wires the case study into docs sidebar, README, and examples readme

Scope note

Documentation and example fixture only — no scanner source changes.

@Ayush7614

Copy link
Copy Markdown
Collaborator Author

@sonukapoor — conflicts with main (after #475 merged) are resolved. Merged latest main into ayush4; Storybook content is unchanged, and both Storybook + Turborepo are wired in the shared docs. Ready for review and merge. Thanks!

@sonukapoor sonukapoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case study content is solid - good verified data, the yarn npm audit comparison (3 vs 92) tells a strong story about what lockfile-wide scanning reveals that default audit scope misses entirely.

Two things before this merges:

Logo should be bundled locally. The current img src points to raw.githubusercontent.com/storybookjs/brand/.... That URL can change or break when the upstream brand repo gets reorganised. The VS Code case study in #484 shows the right pattern - bundle the logo under website/static/img/ and reference it with a site-relative path like /cve-lite-cli/img/storybook-logo.svg. Would be good to match that approach here.

The last commit includes a Cursor co-author line. Co-authored-by: Cursor <cursoragent@cursor.com> will land in git history on merge. Worth squashing that commit into the one before it to keep the history clean. The content is fine - just the attribution.

Pin storybookjs/storybook@cc19ae1 Yarn Berry lockfile (3,008 packages,
92 findings) with CVE Lite vs yarn npm audit comparison. Bundle Storybook
wordmark under website/static/img/ and wire docs sidebar, README, examples
readme, CHANGELOG, and docs index alongside merged VS Code case study.

Closes OWASP#465
@Ayush7614

Copy link
Copy Markdown
Collaborator Author

@sonukapoor — both review items addressed:

  1. Logo bundled locally — Storybook wordmark is now at website/static/img/storybook-logo.svg and referenced as /cve-lite-cli/img/storybook-logo.svg in the case study (same pattern as Add VS Code root lockfile example and verified case study #484).

  2. Clean commit history — Squashed to a single commit on latest main with Ayush7614 as the only author (no Cursor co-author line).

Also rebased onto current main (includes merged VS Code #484) and resolved conflicts in README.md, website/docs/index.md, and website/sidebars.ts — Storybook and VS Code entries are both present.

Ready for re-review.

@sonukapoor sonukapoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous feedback addressed — logo is now bundled at website/static/img/storybook-logo.svg, single clean commit, and all sections are present. The Yarn Berry audit gap is well explained (3 entries vs 92 findings), the five critical chains are clearly traced, and the honest single vite upgrade command is the right first-pass result for a graph this shape. This is merge-ready. Thanks for iterating on it.

@sonukapoor
sonukapoor merged commit 2560e71 into OWASP:main May 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Storybook lockfile example and verified case study

2 participants