Skip to content

Fix config parsing on WeeChat 2.4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcworld wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix config parsing on WeeChat 2.4 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions weechat-remote-notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def run_notify(mtype,urgency,icon,time,nick,chan,message):
host = w.config_get_plugin('host')

try:
if command:
if command and command != ('',):

@pcworld pcworld Nov 17, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command and can probably be deleted at least for my WeeChat build.

p = subprocess.Popen(command, shell=True,
stdin=subprocess.PIPE,
stdout=subprocess.PIPE,
Expand All @@ -111,17 +111,17 @@ def on_msg(*a):
option = w.config_get("weechat.look.prefix_network")
if sender == w.config_string(option):
return w.WEECHAT_RC_OK
if data == "private" or highlight == "1":

if data == "private" or highlight == 1:
#set buffer
buffer = "me" if data == "private" else w.buffer_get_string(buffer, "short_name")

#set time - displays message forever on highlight
if highlight == "1" and data == "private":
if highlight == 1 and data == "private":

@pcworld pcworld Nov 17, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want I can put the old comparison in an or if this is needed for other weechat versions.

mtype = "private_highlight"
icon = w.config_get_plugin('pm-icon')
time = w.config_get_plugin('display_time_private_highlight')
elif highlight == "1":
elif highlight == 1:
mtype = "highlight"
icon = w.config_get_plugin('icon')
time = w.config_get_plugin('display_time_highlight')
Expand Down