1.0.0#1
Open
msigley wants to merge 4 commits into
Open
Conversation
Added 'WP_STACK_CDN_THEME' constant for CDN resources in the current theme. Renamed 'WP_STACK_CDN_UPLOADS_ONLY' constant to 'WP_STACK_CDN_UPLOADS'. Added 'wp_stack_cdn_filter_urls' filter for filtering custom base urls. Added dns-prefetch hint for CDN domain. Reworked init function to streamline logic for additional features.
Author
|
Using this version of the plugin I was able to implement an image only CDN filter on a Shopp site. |
|
Hmm, so why only use the CDN for images? |
Author
|
Render blocking resources like css and js in the mostly. Loading these types of resources from an different domain adds a noticable lag in the render time. Also the previous implementation was an all or nothing approach to url replacement. The new 'wp_stack_cdn_filter_urls' filter allows for custom url replacements to be done as a nice middle ground. There is also the issue of content security policies and loading JS from a different domain. Some scripts will only execute properly when run from the same domain as the website. |
Added 'WP_STACK_CDN_FORCE_HTTPS' definition for enabling/disabling https forcing. Added WP_Stack_CDN_get_url() API function. Implemented singleton.
This bug prevented urls in inline-block layouts from being replaced.
Author
|
@clifgriffin I added several more fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'WP_STACK_CDN_THEME' constant for CDN resources in the current theme.
Renamed 'WP_STACK_CDN_UPLOADS_ONLY' constant to 'WP_STACK_CDN_UPLOADS'.
Added 'wp_stack_cdn_filter_urls' filter for filtering custom base urls.
Added dns-prefetch hint for CDN domain.
Reworked init function to streamline logic for additional features.