Draft
Conversation
Contributor
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
force-pushed
the
braga/consensus-exec-diff-proc
branch
from
be02672 to
b2f5213
Compare
bragaigor
commented
Feb 18, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4386 +/- ##
==========================================
- Coverage 34.73% 32.79% -1.95%
==========================================
Files 489 489
Lines 58125 58157 +32
==========================================
- Hits 20190 19070 -1120
- Misses 34347 35744 +1397
+ Partials 3588 3343 -245 |
Conversily enable consensus only mode in nitro Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
bragaigor
force-pushed
the
braga/consensus-exec-diff-proc
branch
from
e7dacb1 to
da045ab
Compare
bragaigor
commented
Mar 5, 2026
Comment on lines
+569
to
+581
| if consensusNodeEnabled { | ||
| // TODO: where will chainConfig come from in the case (consensusNodeEnabled && !executionNodeEnabled) ? | ||
| var chainConfig *params.ChainConfig | ||
| if !executionNodeEnabled && l2BlockChain == nil { | ||
| genesisBlockNr := uint64(0) | ||
| chainConfig, err = chaininfo.GetChainConfig(new(big.Int).SetUint64(nodeConfig.Chain.ID), nodeConfig.Chain.Name, genesisBlockNr, nodeConfig.Chain.InfoFiles, nodeConfig.Chain.InfoJson) | ||
| if err != nil { | ||
| log.Error("failed to get chainConfig for consensus node", "err", err) | ||
| return 1 | ||
| } | ||
| } else { | ||
| chainConfig = l2BlockChain.Config() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
we'll probably need genesis block number to get parsedInitMSg for consensus (hardcoded above), for which we could add a new command line parameter for it and assign 0 as the default value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable execution only mode in nitro as well as consensus only mode
closes NIT-4241
relates to NIT-4202
pulls in OffchainLabs/nitro-testnode#177