Remove Bazel: Phase 5/9 - #17356
Draft
nalepae wants to merge 1 commit into
Draft
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR implements Phase 5: Implement hermetic release docker image build of:
The new
make helpis now:With the important line being:
docker/arm64anddocker/amd64Docker images can be built using:Using
without any parameters builds all binaries as previously + the Docker images.
Docker images are written in the
distdirectory, as following:To load the docker images in the local registry, use the
docker loadcommand.Example:
And then:
To test the reproducibility of the builds you can pin
SOURCE_DATE_EPOCH, build 2 times and run thediffcommand against the 2 generateddistdirectories. They should contain no difference.Example
Finally, to build a "convenience" docker image (not suitable for releases, but fast to build), you can use:
Default BIN is
beacon-chain.Acknowledgements