Extract shared indexed-list decoders for beacon REST handlers - #17399
Open
syjn99 wants to merge 1 commit into
Open
Extract shared indexed-list decoders for beacon REST handlers#17399syjn99 wants to merge 1 commit into
syjn99 wants to merge 1 commit into
Conversation
syjn99
force-pushed
the
feat/indexed-list-decode
branch
from
August 24, 2026 07:56
c30e1f7 to
9490462
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
As we've added SSZ support for request body, there are some duplicated logics for decoding SSZ/JSON (
decode*{SSZ,JSON}). This PR adds a common decoding functions both for SSZ and JSON based on the callback function passed.This PR also fixes a bug that might be panicked when there's
nullentry in JSON body. (An unit test added:null element keeps failure indices aligned) Also,POST /eth/v2/beacon/pool/attestationsnow doesn't compact the valid attestations; instead, it defines the fixed length of slice and puts valid one via index.Which issue(s) does this PR fix?
N/A
Other notes for review
Acknowledgements