fix: resolve 404 on logout by creating missing API route#818
Open
johdanike wants to merge 3 commits into
Open
Conversation
- Set by default for all new user signups. - Generate and store a 24-hour verification token upon account creation. - Create route to validate tokens and update status. - Build frontend page to handle token processing and redirect. - Restrict escrow creation API and UI to users with verified emails. Closes Ogstevyn#183
- Create `POST /api/auth/logout` endpoint. - Clear JWT authentication cookie server-side using Next.js headers. - Return standard JSON success response for the frontend context. - Add Vitest test suite to verify cookie deletion behavior. Closes Ogstevyn#163
|
@johdanike is attempting to deploy a commit to the Stephen's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@johdanike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related Issue(s)
Closes #660
Summary of Changes
This PR fixes a critical bug where users were unable to properly sign out of the application. The frontend EmailAuthContext was attempting to call POST /api/auth/logout, but the route did not exist, resulting in a 404 error and leaving the user's server-side session active. This introduces the missing endpoint to securely destroy the HTTP-only JWT cookie.
Backend / Core Logic:
Test Suite: