Fix external global variables on replay - #146
Open
ZwFink wants to merge 6 commits into
Open
Conversation
ZwFink
force-pushed
the
fix/foreign-device-global-replay
branch
2 times, most recently
from
April 28, 2026 20:00
01f36ad to
e010e07
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The prologue parser jumped from blob metadata directly to NumPointerOffsets, ignoring the NumArgs / per-arg data section that sits between them. For test_device_global_as_arg this caused NumArgs (=2) to be misread as NumPointerOffsets, making the CHECK-RR line see "PointerOffsets: 2" instead of the actual 1 stored in the .mneme snapshot.
The method was removed from proteus::BinaryInfo in Proteus v2026.03.0; VarNameToGlobalInfo is now populated eagerly via insertGlobalVar() and no explicit mapping step is required.
ZwFink
force-pushed
the
fix/foreign-device-global-replay
branch
from
April 28, 2026 23:05
e010e07 to
accd637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.