Decouple blob ids from recorded device addresses - #188
Open
cmelone wants to merge 2 commits into
Open
Conversation
Mneme stores recorded device addresses as the IDs of blobs, snapshots, and replay pointer values. Working on the subregion annotation feature, I was running into issues where the exact recorded VA base wasn't available. I think this could be ameliorated by storing blob_id along with an offset relative to the VA base, allowing us to manage regions within a blob and reduce dependence on the exact address. Signed-off-by: Caetano Melone <melone1@llnl.gov>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mneme stores recorded device addresses as the IDs of blobs, snapshots, and replay pointer values.
Working on the subregion annotation feature, I was running into issues where the exact recorded VA base wasn't available. I think this could be ameliorated by storing blob_id along with an offset relative to the VA base, allowing us to manage regions within a blob and reduce dependence on the exact address.