Skip to content

Added Laghos integration tests for Tuo and Tioga - #55

Open
lpottier wants to merge 21 commits into
developfrom
54-add-laghos-to-mneme-ci
Open

Added Laghos integration tests for Tuo and Tioga#55
lpottier wants to merge 21 commits into
developfrom
54-add-laghos-to-mneme-ci

Conversation

@lpottier

@lpottier lpottier commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@lpottier lpottier linked an issue Sep 24, 2025 that may be closed by this pull request
Add Laghos to Mneme CI #54
Open
@lpottier
lpottier requested a review from koparasy September 25, 2025 19:44
koparasy
koparasy requested changes Sep 26, 2025
View reviewed changes

@koparasy koparasy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it seems a good starting point. We need to clean this up. I will describe how on the next post.

Comment thread .gitlab/jobs/tuolumne.yml Outdated
Comment thread .gitlab/jobs/tuolumne.yml Outdated
Comment thread .gitlab/subscribed-pipelines.yml Outdated
Comment thread src/python/profile/rocr_profile.cpp
koparasy
koparasy reviewed Sep 26, 2025
View reviewed changes
Comment thread scripts/gitlab/ci-build-test.sh Outdated
@koparasy

koparasy commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

Great work here 🎉 With a little bit of refactoring, we’ll have it in great shape for merge.

One improvement I’d suggest is separating the code for running Laghos from the rest of the testing. To get there, you’ll need to set up some new pipelines. Here’s a possible path forward:

  1. Create a new base pipeline. You can check out an example here
  2. Instruct GitLab to use a different script as an entry point, similar to this example
  3. Create a YAML describing the matrix, modeled after this file

Once that’s in place, you’ll be able to move most of your code into a separate script and have a clean entry point just for Laghos.

Thanks again for pushing this forward — excited to see it come together! 🚀

@lpottier

lpottier commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

@koparasy Thanks for the review! I agree it's better to separate Laghos from the rest. I will create a new pipeline as suggested.

@lpottier
lpottier requested a review from koparasy September 29, 2025 18:22
@koparasy

koparasy commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

Ok. I need some extra modification. I don't want to execute this always. So, I want to have a command:

/run-laghos

that I can post as a comment in a PR. Once someone post it, it will start the laghos run as you do. We do this in proteus here until here .

I don't want the rest of the infrastructure to post the results back up. But just have us optionally start stop the run.

@lpottier

lpottier commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator Author

@koparasy That's a good idea. Let me work on that.

@lpottier
lpottier force-pushed the 54-add-laghos-to-mneme-ci branch from 043f813 to 180e3d7 Compare September 30, 2025 00:08
@koparasy
koparasy force-pushed the 54-add-laghos-to-mneme-ci branch from 180e3d7 to e1374be Compare September 30, 2025 22:00
lpottier and others added 15 commits September 30, 2025 16:58
@lpottier
Added Laghos integration tests for Tuo and Tioga
b261e3a 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Reactivated commented tests
58c9c1d 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Automatic selection of a kernel and setting MNEME_LOG_LEVEL to critic…
1251471 
…al to avoid log limit on GitLab runners

Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Temporarily deactivating Tioga and most of the test to focus on Tuo+R…
4550a38 
…OCm 6.3.1

Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Reactivating all tests
81bfeea 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Testing two concurrent jobs
f441eed 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Removing const identifier which breaks with ROCm 6.2.1
2bcaaa7 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
reactivating ROCm 6.2.1 tests
5d6d09a 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Separate integration tests with Laghos in its own pipeline
70b79fd 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Giving more time to the runners
04435e8 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Missing guard in db.py/add (#57)
0dbc123 
* Added guard against exp being None in db.py/add
* Deactivated Lassen tests

---------

Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Deactivating Lassen tests
9351e0b 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Fixed rebase mistake
22da3da 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Cleaning up Lassen-related tests
8fb7d64 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
Fixed a missing guard against None value in Mneme DB
2504926 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier
lpottier force-pushed the 54-add-laghos-to-mneme-ci branch from e1374be to 2504926 Compare September 30, 2025 23:58
@lpottier

lpottier commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator Author

/run-laghos

@lpottier

lpottier commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator Author

/run-laghos

@lpottier
Added time measurements and debug print
f02e42c 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier

lpottier commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator Author

/run-laghos

@lpottier

lpottier commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator Author

/run-laghos

@lpottier
Empty commit to trigger the CI
b6f5758 
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@lpottier

lpottier commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

/run-laghos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koparasy koparasy Awaiting requested review from koparasy

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Laghos to Mneme CI

2 participants

@lpottier @koparasy