feature: Add interface for plugin pass - #496
Merged
Merged
Conversation
Collaborator
Author
|
@jandrej this PR is the first step in towards solving compatibility between Proteus and Enzyme |
johnbowen42
changed the title
johnbowen42
marked this pull request as ready for review
May 27, 2026 23:23
Collaborator
|
Why only for serial codegen? |
ZwFink
requested changes
Jun 4, 2026
ZwFink
left a comment
ZwFink
left a comment
Collaborator
There was a problem hiding this comment.
Nice changes! I have a couple small issues
Collaborator
Author
@ZwFink We only ever call |
Collaborator
|
LGTM, but I'll delegate acceptance to @ZwFink, who has a more recent view of the codebase. I see some trivial issues with tests (linter and matrix was probably down) Does it solve the issue with including the enzyme plugin? |
ZwFink
force-pushed
the
feature/bowen/support-plugin-pass-jit
branch
from
July 1, 2026 21:58
d538cd1 to
827ea0e
Compare
ZwFink
force-pushed
the
feature/bowen/support-plugin-pass-jit
branch
from
July 7, 2026 16:14
335c3f5 to
c0c8db9
Compare
ZwFink
approved these changes
Jul 7, 2026
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
ZwFink
force-pushed
the
feature/bowen/support-plugin-pass-jit
branch
from
July 8, 2026 16:49
c0c8db9 to
0c893a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want our lambda interface to be compatible with Enzyme. Towards this end, this PR adds an option to run a user-supplied plugin pass as part of the optimization pipeline at JIT optimization time