add worklist sorting to support nested specializations - #513
Open
jandrej wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jandrej
changed the title
johnbowen42
requested changes
Sep 3, 2026
johnbowen42
left a comment
johnbowen42
left a comment
Collaborator
There was a problem hiding this comment.
Once we remove the nested device compilation support (which I think is already supported), this will be good to merge in
| void **KernelArgs, uint64_t ShmemSize, void *Stream); | ||
|
|
||
| extern "C" proteus::DeviceTraits<JitDeviceImplT>::DeviceError_t | ||
| __proteus_launch_kernel_by_name(const char *KernelLookupKey, dim3 GridDim, |
Collaborator
There was a problem hiding this comment.
Let's avoid duplicating the interface for the nested device case. I think if we pull this out, we will be ready to go.
|
|
||
| extern "C" unsigned __cudaPushCallConfiguration(dim3 GridDim, dim3 BlockDim, | ||
| size_t SharedMem, void *Stream); | ||
| extern "C" cudaError_t __cudaPopCallConfiguration(dim3 *GridDim, dim3 *BlockDim, |
johnbowen42
reviewed
Sep 3, 2026
| } | ||
| #endif | ||
|
|
||
| #if PROTEUS_ENABLE_CUDA |
Collaborator
There was a problem hiding this comment.
remove all this as well while taking out the device change
| // Post-order over the nesting relation, so an inner JIT function is always | ||
| // processed before the ones containing it. Recursion through JIT functions | ||
| // has no innermost region, so a cycle keeps its original relative order. | ||
| SmallVector<JitWorkListEntry *, 16> sortJitWorkListInnermostFirst( |
Collaborator
There was a problem hiding this comment.
this topological ordering is a good change as well to make sure we have a deterministic ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #512