Open
Conversation
- Convert textSize string to float in bindLabels call - Fix pin lambda to call bindPinned instead of shadowed variable
- Pass search keyword when navigating from search results - Highlight matching text in title, body, and list items - Skip BackgroundColorSpan when saving to prevent persistence - Clear search keyword when leaving search view
- Remove createBaseNote call from setState - Only save note when content is not empty - Handle new note creation in saveNote method
- Swipe across notes to select/deselect them - Start selection mode by swiping past 30% of an item width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Om
When searching for items, I found that when note contents are with more than 20 lines, it's very difficult to target the searched content instantly. This pr would highlight the content that's searched.
Note: the last pr's compile errors fix is included here.
Add search term highlighting when viewing notes