Rebrand project to Omni Core by dexX7 · Pull Request #91 · OmniLayer/omnicore

dexX7 · 2015-06-25T02:47:55Z

This PR rebrands the project to Omni Core.

It updates file names, including setup packages. I haven't tested it cross-plattform, and neither the installers.

Given that Travis failed a few times, due to some mistakes, I'm somewhat confident that it's going to work though. Nevertheless, testing should be done rather sooner than later, with special attention to default datadirs, install locations and more importantly: deinstallation routines.

It resolves #10, and it resolves #97.

Edit:

I added resource files for the Windows binaries: src/omnicore/res, and started with the documentation src/omnicore/doc. This isn't intended to finalize the docs, but rather to have the file structure for the setup script.

The Omni Core version needs to be defined in configure.ac as well as in src/omnicore/version.h. The values of the configure file are used to replace placeholder values in other files like the setup script.

The version is still "0.0.10.0-dev", and I called the very first digit "milestone". This is for no particular reason, but it needed to be defined somehow.

When building, we end up with the following binaries:

src/omnicore-cli
src/omnicored
src/test/test_omnicore
src/qt/omnicore-qt
src/qt/test/test_omnicore-qt

The installer for Windows is currently build with the file name omnicore-0.0.10.0-dev-win64-setup.exe, and this is based on the values used in the configuration file.

When using the Windows installer, the following files are created or copied to the install destination:

daemon\omnicored.exe
daemon\omnicore-cli.exe
doc\*.*
copying.txt
omnicore-qt.exe
readme.txt
release-notes.txt
uninstall.exe

This is similar to the original Bitcoin Core behavior, except that it uses Omni Core related documents.

On OS X it should be OmniCore-Qt.app. I haven't tested it yet, but I also haven't touched that part in the recent update of this PR.

dexX7 · 2015-06-25T03:31:31Z

On hold until I tested the results.

dexX7 · 2015-06-25T04:27:11Z

Windows works fine! :)

To do:

test Gitian building for Windows
test Gitian building for OS X
test Gitian building for Ubuntu
test installation in Windows
test installation in Ubuntu
test installation in Mac OS X
replace installer icon
replace setup images
define what goes into the package (right now the release notes, and a few other docs are copied)

zathras-crypto · 2015-06-26T01:28:12Z

Nice, nice, nice. Every day I get up to such great work from you bud :)

Re installation in Ubuntu, is there even an installer for Ubuntu? I thought they were delivered as straight bins?

Re installation in OSX, if you have an installer you'd like me to try out more than happy to :)

Do you need any help with the images?

dexX7 · 2015-06-26T02:49:47Z

Thanks! :)

Re installation in Ubuntu, is there even an installer for Ubuntu? I thought they were delivered as straight bins?

Ah, right. Let me rephrase: I haven't tested the build route for Unix.

Re installation in OSX, if you have an installer you'd like me to try out more than happy to :)

These are the results of the earlier builds:

http://bitwatch.co/uploads/builds/2015-06-05-gitian-osx-win.rar

Please ping me, once you got them. :)

Do you need any help with the images?

That would be awesome!

share/setup.nsi.in describes the setup on Windows, and this section sets the icons and images:

# MUI Symbol Definitions
!define MUI_ICON "@abs_top_srcdir@/share/pixmaps/bitcoin.ico"
!define MUI_WELCOMEFINISHPAGE_BITMAP "@abs_top_srcdir@/share/pixmaps/nsis-wizard.bmp"
!define MUI_HEADERIMAGE
!define MUI_HEADERIMAGE_RIGHT
!define MUI_HEADERIMAGE_BITMAP "@abs_top_srcdir@/share/pixmaps/nsis-header.bmp"
!define MUI_FINISHPAGE_NOAUTOCLOSE
!define MUI_STARTMENUPAGE_REGISTRY_ROOT HKLM
!define MUI_STARTMENUPAGE_REGISTRY_KEY ${REGKEY}
!define MUI_STARTMENUPAGE_REGISTRY_VALUENAME StartMenuGroup
!define MUI_STARTMENUPAGE_DEFAULTFOLDER "@PACKAGE_NAME@"
!define MUI_FINISHPAGE_RUN $INSTDIR\bitcoin-qt.exe
!define MUI_UNICON "${NSISDIR}\Contrib\Graphics\Icons\modern-uninstall.ico"
!define MUI_UNWELCOMEFINISHPAGE_BITMAP "@abs_top_srcdir@/share/pixmaps/nsis-wizard.bmp"
!define MUI_UNFINISHPAGE_NOAUTOCLOSE

So these are the ones we should replace:

- share/pixmaps/bitcoin.ico
- pixmaps/nsis-header.bmp
- pixmaps/nsis-wizard.bmp

zathras-crypto · 2015-06-26T04:01:36Z

Please ping me, once you got them. :)

Got them :)

zathras-crypto · 2015-06-27T05:29:44Z

So these are the ones we should replace

How about these? #102

These files are mostly placeholders.

The resource files and installer script define file properties, as well as steps taken during the installation on Windows. The Omni Core version is set via configure.ac, and picked up for the setup and resource descriptions. The versioning scheme itself hasn't changed, and the current version is still "0.0.10.0-dev".

dexX7 · 2015-07-01T02:57:21Z

Prr.. this PR wasn't fun.

I added resource files for the Windows binaries: src/omnicore/res, and started with the documentation src/omnicore/doc. This isn't intended to finalize the docs, but rather to have the file structure for the setup script.

The Omni Core version needs to be defined in configure.ac as well as in src/omnicore/version.h. The values of the configure file are used to replace placeholder values in other files like the setup script.

The version is still "0.0.10.0-dev", and I called the very first digit "milestone". This is for no particular reason, but it needed to be defined somehow.

When building, we end up with the following binaries:

src/omnicore-cli
src/omnicored
src/test/test_omnicore
src/qt/omnicore-qt
src/qt/test/test_omnicore-qt

The installer for Windows is currently build with the file name omnicore-0.0.10.0-dev-win64-setup.exe, and this is based on the values used in the configuration file.

When using the Windows installer, the following files are created or copied to the install destination:

daemon\omnicored.exe
daemon\omnicore-cli.exe
doc\*.*
copying.txt
omnicore-qt.exe
readme.txt
release-notes.txt
uninstall.exe

This is similar to the original Bitcoin Core behavior, except that it uses Omni Core related documents.

On OS X it should be OmniCore-Qt.app. I haven't tested it yet, but I also haven't touched that part in the recent update of this PR.

msgilligan · 2015-07-01T04:58:18Z

I submitted a PR a while back with Mac OS X rebranding (Bitcoin -> 'Master Core') so I can check out the Mac OS build process for the same issues.

dexX7 · 2015-07-01T14:21:33Z

This would be really great!

In these files are the Mac specific changes:

When comparing it with mastercoin-MSC#203, it seems to add up.

I did not change the CFBundleIdentifier in Info.plist.in though. According to developer.apple.com:

CFBundleIdentifier (String - iOS, OS X) uniquely identifies the bundle. Each distinct app or bundle on the system must have a unique bundle ID. The system uses this string to identify your app in many ways. For example, the preferences system uses this string to identify the app for which a given preference applies;

We should use an unqiue identifier, but I wasn't sure, if this has an impact on Bitcoin Core settings, i.e. "ideally a former Bitcoin Core user should be able to switch to Omni Core and back with ease".

zathras-crypto · 2015-07-02T02:08:53Z

On OS X it should be OmniCore-Qt.app. I haven't tested it yet

The name is correct but the icon is still the Bitcoin Core icon:

Interestingly the dock icon starts with the Bitcoin Core icon but changes to the correct icon during initialization:

dexX7 · 2015-07-02T14:16:11Z

Hehe interesting.

We have the following images to update:

Installer: contrib/macdeploy/background.png (there is also a .psd)

I haven't found a reference in the OS X files to pin down the icon, but it's probably one of the following:

share/pixmaps/bitcoin.ico (via share/ui.rc, which is not referenced)
share/pixmaps/favicon.ico (via share/ui.rc, which is not referenced)
share/pixmaps/bitcoinN.png (used by contrib/debian/...)
src/qt/res/src/bitcoin.svg (not referenced)

There is also contrib/macdeploy/DS_Store, which is part of OSX_PACKAGING via the Makefile, though I'm not sure, if this has any relevance here:

.DS_Store is the name of a file in the Apple OS X operating system for storing custom attributes of a folder such as the position of icons or the choice of a background image. (wikipedia)

There are also a few references to:

https://github.com/OmniLayer/omnicore/blob/omnicore-0.0.10/src/qt/res/icons/bitcoin.icns

Based on the commit description 72fcbb1, it seems to be related to the svg, and my bet: this is the one we'd have to update.

dexX7 · 2015-07-03T12:20:43Z

@zathras-crypto: do you have any higher resolution Omni images? Or could you maybe even replace bitcoin.icns? :) Other than that, I think this PR is ready.

zathras-crypto · 2015-07-06T06:55:43Z

do you have any higher resolution Omni images?

I do but not with transparent backgrounds to use for a higher res icon :( I'll arrange to get some originals but for now #114 should do the trick.

Other than that, I think this PR is ready.

Agreed, looks good to me :)

30fdde4 Update package version and resource files (dexX7) 052297b Lay out structure for Omni Core documentation (dexX7) c628147 Rebrand to Omni Core (file level) (dexX7) 89f19c6 Rebrand to Omni Core (dexX7)

dexX7 added the status: on hold label Jun 25, 2015

This was referenced Jun 25, 2015

Prepare installers, replace icons, define version #97

Closed

Release process and plan for 0.0.10 #93

Closed

dexX7 force-pushed the oc-0.10-rebrand-to-omni branch 2 times, most recently from 46e8b7c to 2f4f5fc Compare June 30, 2015 14:54

dexX7 added status: in progress and removed status: on hold labels Jun 30, 2015

dexX7 force-pushed the oc-0.10-rebrand-to-omni branch 3 times, most recently from 871e315 to 7870578 Compare June 30, 2015 21:55

dexX7 added 3 commits July 1, 2015 03:00

Rebrand to Omni Core

89f19c6

Rebrand to Omni Core (file level)

c628147

Lay out structure for Omni Core documentation

052297b

These files are mostly placeholders.

dexX7 force-pushed the oc-0.10-rebrand-to-omni branch 8 times, most recently from 788a847 to c96c160 Compare July 1, 2015 02:25

dexX7 added status: ready and removed status: in progress labels Jul 1, 2015

dexX7 force-pushed the oc-0.10-rebrand-to-omni branch from c96c160 to 30fdde4 Compare July 1, 2015 02:40

dexX7 mentioned this pull request Jul 1, 2015

Rename artifact files and scripts from "bitcoin*" to "omnicore*" OmniLayer/OmniJ#88

Closed

dexX7 merged commit 30fdde4 into OmniLayer:omnicore-0.0.10 Jul 6, 2015

dexX7 modified the milestone: 0.0.10.0 Dec 30, 2015

Conversation

dexX7 commented Jun 25, 2015

Uh oh!

dexX7 commented Jun 25, 2015

Uh oh!

dexX7 commented Jun 25, 2015

Uh oh!

zathras-crypto commented Jun 26, 2015

Uh oh!

dexX7 commented Jun 26, 2015

Uh oh!

zathras-crypto commented Jun 26, 2015

Uh oh!

zathras-crypto commented Jun 27, 2015

Uh oh!

dexX7 commented Jul 1, 2015

Uh oh!

msgilligan commented Jul 1, 2015

Uh oh!

dexX7 commented Jul 1, 2015

Uh oh!

zathras-crypto commented Jul 2, 2015

Uh oh!

dexX7 commented Jul 2, 2015

Uh oh!

dexX7 commented Jul 3, 2015

Uh oh!

zathras-crypto commented Jul 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants