feat(btc): expose coinselect sortingStrategy for deterministic output ordering, OK-50996

[originalix]

Summary

• Expose sortingStrategy parameter through coinSelectWithWitness to control BTC transaction output ordering
• For swap/protocol transactions (detected by opReturn presence), use 'none' strategy to guarantee payment address as the first output
• Regular transfers continue using default 'random' strategy for privacy

Intent & Context

Third-party protocols (e.g., THORSwap) require the to address to appear as the first output in BTC transactions. The @onekeyfe/coinselect SDK uses a 'random' sorting strategy by default, which randomly inserts the change output before or after the payment output (~50% chance). This breaks protocol requirements.

The coinselect SDK was updated in OneKeyHQ/coinselect#17 to accept an optional sortingStrategy parameter. This PR wires that parameter through the app-monorepo call chain.

Design Decisions

• Detection via opReturn: Presence of opReturn in transfersInfo reliably indicates a protocol transaction (THORSwap, etc.), not a regular user transfer. This avoids adding new fields to ITransferInfo.
• Scoped impact: Only swap/protocol transactions are affected. Regular BTC transfers keep 'random' sorting for privacy (prevents observers from identifying payment vs change outputs by position).
• undefined as default: When no sortingStrategy is passed, the SDK defaults to 'random', maintaining full backward compatibility.

Changes Detail

• packages/core/src/utils/coinSelectUtils.ts: Added ICoinSelectSortingStrategy type; added sortingStrategy to ICoinSelectWithWitnessOptions and passed it through to the SDK
• packages/kit-bg/src/vaults/impls/btc/Vault.ts: Pass sortingStrategy: 'none' when opReturn is present in transfer info

Risk Assessment

• Risk Level: Low
• Affected Platforms: All (Extension / Mobile / Desktop / Web)
• Risk Areas: Only affects BTC transactions that go through local coin selection with opReturn (THORSwap-style swaps). Regular transfers and PSBT-based swaps are unaffected.

Test plan

• Verify regular BTC transfers still work with randomized output ordering
• Verify BTC swap transactions with opReturn produce payment address as first output
• Verify PSBT-based swaps (non-THORSwap) are unaffected

---

[revan-zhang]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53f7835c05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​babel/​plugin-proposal-class-properties@​7.18.6
	@​babel/​plugin-proposal-class-static-block@​7.21.0
	@​babel/​plugin-proposal-nullish-coalescing-operator@​7.18.6
	@​babel/​plugin-proposal-private-methods@​7.18.6
	@​babel/​plugin-proposal-private-property-in-object@​7.21.11
	@​aptos-labs/​ts-sdk@​1.39.0
	@​babel/​plugin-transform-numeric-separator@​7.25.9
	@​expo/​plist@​0.1.3
	@​types/​node-fetch@​2.6.9
	@​bottom-tabs/​react-navigation@​1.1.0
	@​aptos-labs/​siwa@​0.4.0
	@​babel/​preset-typescript@​7.27.1
	esbuild@​0.27.2
	@​babel/​plugin-transform-optional-chaining@​7.27.1 ⏵ 7.25.9	+1		+1
	@​formatjs/​intl-pluralrules@​4.3.3
	expo-keep-awake@​14.1.4
	@​formatjs/​intl-locale@​2.4.47
	@​formatjs/​intl-getcanonicallocales@​1.9.2
	@​babel/​preset-env@​7.28.6
	@​glif/​filecoin-rpc-client@​3.0.2
	@​benfen/​bfc.js@​0.2.7
	@​alephium/​web3@​1.5.2
	@​babel/​core@​7.27.1
	@​glif/​filecoin-message@​2.0.44
	@​electron/​remote@​2.1.1
	@​cityofzion/​neon-core@​5.7.0
	@​ckb-lumos/​ckb-indexer@​0.23.0
	@​emurgo/​cardano-message-signing-nodejs@​1.0.1
	@​cowprotocol/​contracts@​1.7.0
	@​ckb-lumos/​common-scripts@​0.23.0
	@​electron/​notarize@​2.3.2
	@​aivenio/​tsc-output-parser@​2.1.1
	@​glif/​filecoin-address@​2.0.43
See 9 more rows in the dashboard

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Critical CVE: Elliptic's private key extraction in ECDSA upon signing a malformed input (e.g. a string) CVE: GHSA-vjh7-7g9h-fjfh Elliptic's private key extraction in ECDSA upon signing a malformed input (e.g. a string) (CRITICAL) Affected versions: < 6.6.1 Patched version: 6.6.1 From: ? → npm/elliptic@6.5.4 ℹ Read more on: This package | This alert | What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/elliptic@6.5.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: npm @emurgo/cardano-message-signing-asmjs is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: ? → npm/@emurgo/cardano-message-signing-asmjs@1.0.1 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@emurgo/cardano-message-signing-asmjs@1.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report