-
Notifications
You must be signed in to change notification settings - Fork 521
fix: update redemption code and Prime KYT copy(OK-57249) #12267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8a12046
88dc038
5dfbde7
8ac876c
a9e7048
8e6eef1
eec4d9c
04c0d4d
acf3662
4206ee6
3deeb22
94aa982
3417106
2d48ae0
8ac0cc6
843218c
e456b57
d81bbab
360433f
5fdd0c5
4854bc8
898ec93
4225c23
b1335ce
6ee29ac
8cfa0e0
b504a64
1b6a494
aa6b5cc
48dfa20
92e8446
a5045f2
ff4785a
2bdc350
0854d01
41f6633
82a9cf5
7d939d4
d1ce1fb
438d3e4
93b13b2
0f60aec
fb8a598
3e50301
3496f5f
5547ac3
321a7bf
7f85bd9
5d2d446
cb9be1c
685418b
a5826e4
2f0168f
60fd6e3
f103d3c
20fc457
c34d5f3
af0e636
be0d02b
3331b77
09d6214
16ac1cc
f078071
920a95e
08a3b64
84fab96
21ef4d4
ae0abd5
11cdf04
6b19a4c
ecaaa91
1f00cce
0d33952
de0168e
9cc4206
cf7a4c8
ab9d00a
b6a894e
923ca13
c13edac
e4bbd9f
d097699
e6f57ad
bab153a
893b770
a0d7cc2
97cfe5a
29c36ee
cb02936
edf7323
ff39a41
c55fc32
4ce72da
24f080e
5cc1007
9d5d53d
17d6542
6c87215
55e1b4e
7f0636a
4dbf6e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -160,14 +160,18 @@ function useKYTIntroDialog() { | |
| onekeyUserIdRef.current = onekeyUserId; | ||
|
|
||
| const showDialog = useCallback(() => { | ||
| const title = `${intl.formatMessage({ | ||
| id: ETranslations.prime_status_prime, | ||
| })} ${intl.formatMessage({ | ||
| id: ETranslations.prime_feature_receive_risk_monitoring__title, | ||
| })}`; | ||
|
|
||
| defaultLogger.prime.usage.primeReceiveKytIntroShown( | ||
| receiveKytIntroTrackingParams, | ||
| ); | ||
| Dialog.show({ | ||
| icon: 'ShieldCheckDoneOutline', | ||
| title: intl.formatMessage({ | ||
| id: ETranslations.prime_feature_receive_risk_monitoring__title, | ||
| }), | ||
| title, | ||
|
Comment on lines
+163
to
+174
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only the intro dialog prepends 'Prime' to the feature title — other usages unchanged Type: The translation key |
||
| showFooter: true, | ||
| onConfirmText: intl.formatMessage({ | ||
| id: ETranslations.kyt_receive_risk_monitoring_enable__action, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当这个 KYT 引导弹窗在非英语 locale 下展示时,这里会把
Prime和功能标题用固定空格直接拼成一条字符串。这样翻译层无法决定完整句子的词序、分隔符和标点,19 个 locale 虽然都改了 copy,但标题这一段仍然不是可翻译的最终文案,部分语言会留下生硬或不一致的标题。
建议把这里改成一个完整的 i18n key,让各语言直接维护整句标题,而不是在代码里拼接两个片段。