fix: apply packaged runtime patches dynamically#12435
Open
huhuanming wants to merge 4 commits into
Open
Conversation
huhuanming
requested review from
ezailWang,
originalix,
revan-zhang and
sidmorizon
as code owners
July 10, 2026 13:35
huhuanming
enabled auto-merge (squash)
July 10, 2026 13:35
sidmorizon
reviewed
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent & Context
Electron Builder installs production dependencies independently under
apps/desktop/app/node_modules. Rootpatch-packagepatches therefore do not automatically reach externalized or transitive dependencies shipped from appDir.The previous implementation detected packaged patched dependencies dynamically, but remediation still copied a hardcoded file list from selected workspace packages and verified hardcoded markers. That left a maintenance gap whenever a new patched dependency or patched file entered the packaged tree.
Design
patches/*.patchfile and derive its package name and version from the patch itself.node_modules, including scoped, nested, and duplicate instances.git apply --check:node_modulesis no longer used as a patch source.Changes
git applyhelpers.apply-runtime-patches.jsto dynamically apply complete committed patches to every matching runtime instance.audit-packaged-runtime-patches.jsas the independent dynamic verification step.packaged-runtime-patches.js,verify-runtime-patches.js, and the updater-specific file list.install-app-depsto install, dynamically apply, and dynamically audit.Risk Assessment
git applybehavior and recursive appDir dependency discovery. The build fails before packaging on any ambiguity, version mismatch, or drift.Test plan
yarn install-app-deps, including Electron native dependency rebuild.@sentry/browser@8.42.0andelectron-updater@6.8.9to pristine content, then verify the dynamic script applies both complete patches.git diff --check.yarn agent:check --profile commitsuccessfully.