feat: add Storybook component playground and prune covered Gallery demos#12465
Merged
Conversation
…op Gallery Checkbox.Group demo
…ext/Markdown stories
…nt/Blur/Pulse/HeightTransition)
…r/Theme/Video stories
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
franco-chan
marked this pull request as ready for review
July 20, 2026 03:11
franco-chan
requested review from
huhuanming,
originalix and
sidmorizon
as code owners
July 20, 2026 03:11
franco-chan
enabled auto-merge (squash)
July 20, 2026 03:30
originalix
reviewed
Jul 20, 2026
originalix
reviewed
Jul 20, 2026
originalix
approved these changes
Jul 20, 2026
originalix
disabled auto-merge
July 20, 2026 07:14
franco-chan
added a commit
that referenced
this pull request
Jul 20, 2026
Resolve the Gallery conflicts from the Storybook playground PR (#12465), which pruned Gallery demos for components now covered by CSF stories. Keep the SetupStepItem Gallery page: it is a kit-level Onboarding v2 component, and the playground deliberately excludes @onekeyhq/kit imports, so it cannot be hosted as a CSF story. This matches the 61 kit-level Gallery routes x kept. Take x's deletions for every component it did move to stories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated component workbench (
apps/playground) with one shared CSF story set rendered by two shells, and removes the kit Gallery demo pages those stories now cover — so component demos have a single maintained surface going forward.yarn workspace @onekeyhq/playground sb:dev(port 6006).@storybook/react-nativeunderapps/mobile/.rnstorybook, rendering the same stories inside the real app runtime.@onekeyhq/components; 15 components intentionally excluded with reasons documented inapps/playground/README.md.EGalleryRoutespruned 119 → 66 withgalleryScreenListregistrations removed in pairs, keeping the dev URL allowlist consistent.What Gallery keeps
Kit-level component pages (AccountAvatar, AddressInput, Token, …), dev/debug tool pages (LocalDB, Hardware, Logger, …), token/typography reference pages (Typography, ThemeColors, Font), and the Gallery pages for documented story exclusions (ImageCrop, RefreshControl, Shortcut, RichSizeableText).
Ripple fixes
NavigatorRoutebig-list demo modal previously mounted the deleted Icon gallery page — replaced with a self-contained 500-row ListView so the virtualization-in-modal demo still works.galleryLastRoutepin, since MMKV/localStorage may still hold a route that no longer exists.Verification
yarn agent:check --profile commitpassed on every commit;--profile prpasses on the final branch./dev/components: home lists exactly the kept pages, search filters correctly, kept pages open, deleted URLs (e.g./dev/component-Button) fall through to Not Found, zero new console errors. The singlecomponent-Navigation not founddev log is pre-existing (enum member never had a registered screen) and intentionally untouched.apps/playground/README.md.Notes for reviewers
xis release-frozen; ready for review once the freeze lifts.apps/playgroundis a standalone workspace that ships nowhere.