Skip to content

feat: add bundle info copy action #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
limichange wants to merge 1 commit into
base: x
Choose a base branch
from
Open

feat: add bundle info copy action #12522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions packages/kit/src/views/Setting/pages/DevBundleSwitcher/BundleList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
Stack,
XStack,
YStack,
useClipboard,
} from '@onekeyhq/components';
import backgroundApiProxy from '@onekeyhq/kit/src/background/instance/backgroundApiProxy';
import { encodeBundleVersionForDisplay } from '@onekeyhq/shared/src/appUpdate';
Expand Down Expand Up @@ -82,6 +83,7 @@ export function BundleItem({
gpgSkipped: boolean;
skipGpgVerificationAllowed: boolean;
}) {
const { copyText } = useClipboard();
const downloadPercent = useDownloadProgress();
const [status, setStatus] = useState<
'idle' | 'downloading' | 'downloaded' | 'installing' | 'error'
Expand Down Expand Up @@ -253,6 +255,17 @@ export function BundleItem({
skipGpgVerificationAllowed,
]);

const handleCopyBundleInfo = useCallback(() => {
copyText(
[
`CI Bundle Version: ${bundle.ciBundleVersion}`,
`Branch: ${bundle.branch ?? ''}`,
`PR Title: ${bundle.prTitle ?? ''}`,
`Build Number: ${bundle.buildNumber ?? ''}`,
].join('\n'),
);
}, [bundle, copyText]);

const downloadDisabled = isDownloading && status !== 'downloading';

return (
Expand Down Expand Up @@ -281,17 +294,26 @@ export function BundleItem({
) : null}
</XStack>

{!isCurrentBundle && (status === 'idle' || status === 'error') ? (
<XStack alignItems="center" gap="$2" flexShrink={0}>
<IconButton
testID="setting-download-disabled-icon-btn"
icon="DownloadOutline"
testID="setting-copy-bundle-info-icon-btn"
icon="Copy3Outline"
size="small"
variant="tertiary"
disabled={downloadDisabled}
onPress={handleDownload}
flexShrink={0}
title="Copy bundle info"
onPress={handleCopyBundleInfo}
/>
) : null}
{!isCurrentBundle && (status === 'idle' || status === 'error') ? (
<IconButton
testID="setting-download-disabled-icon-btn"
icon="DownloadOutline"
size="small"
variant="tertiary"
disabled={downloadDisabled}
onPress={handleDownload}
/>
) : null}
</XStack>
</XStack>

{/* Row 2: buildNumber + ciBundleVersion (encoded) + fileSize */}
Expand Down
Loading