chore(desktop): upgrade Electron to 43.1.1#12543
Draft
huhuanming wants to merge 1 commit into
Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
node-abifor Electron 43node-fetchto Node 24 nativefetch, removing the obsoletetr46runtime pinelectron-logto 5.4.4 and add narrowly scoped runtime patches for@sentry/electron@5.8.0andbytebuffer@5.0.1Why
Electron 39.8.9 is EOL. Electron 43.1.1 supplies the supported Electron 43 runtime with Chromium 150 and Node 24.
The Electron 43 warning trace also exposed three third-party compatibility paths:
electron-log@5.2.0called deprecatedsession.getPreloads/setPreloads; 5.4.4 usesregisterPreloadScriptnode-fetch@2pulledwhatwg-url@5/tr46@0.0.3, which loaded deprecated corepunycodebytebuffer@5.0.1, reached through the hardware transport stack, used deprecatedBuffer()constructors@sentry/electron@5.8.0retains the same old session API in an optional preload-injection path; the patch backports the upstream feature-detectedregisterPreloadScriptimplementation without forcing a cross-platform Sentry major upgradeCompatibility impact
Checks
yarn install --immutable --mode=skip-buildyarn _tscyarn agent:check --profile commityarn workspace @onekeyhq/desktop install-app-depsOneKey, URLfile:///, 1536×852 visible UI, account/token/activity data loaded--trace-warnings --trace-deprecation: 0 matches forgetPreloads/setPreloads,DEP0040/punycode,DEP0005/Buffer(), fatal exceptions, or unhandled rejectionsCI matrix requested