Fix/cardano partial sign#15
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
这个是暂时不合入的吧 |
ByteZhang1024
enabled auto-merge (squash)
April 14, 2026 00:25
originalix
approved these changes
Apr 14, 2026
Two runtime crashes triggered by CSL 13 API changes that went unnoticed because the affected code paths (hardware dApp signing with Plutus reference_inputs or mint) had no real test coverage. - reference_inputs: CSL 13 TransactionInput.index() returns a JS number directly, not a BigNum, so the legacy .to_str() call crashes with "not a function". Wrap with String() for safe numeric parsing. - mint: CSL 13 changed Mint.get(policy) to return MintsAssets — a list of MintAssets entries, one per occurrence of that policy in the original CBOR, to preserve byte-level round-trip (tx hash stability). Iterate the list, then each map, instead of the old single-map access.
ByteZhang1024
force-pushed
the
fix/cardano-partial-sign
branch
from
April 14, 2026 05:39
82b4ebe to
100f676
Compare
huhuanming
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.