Skip to content

[Snyk] Security upgrade requests from 2.31.0 to 2.33.0#191

Open
revan-zhang wants to merge 1 commit into
masterfrom
snyk-fix-c491fc514b9018a5c7756dbbb8dbf8c1
Open

[Snyk] Security upgrade requests from 2.31.0 to 2.33.0#191
revan-zhang wants to merge 1 commit into
masterfrom
snyk-fix-c491fc514b9018a5c7756dbbb8dbf8c1

Conversation

@revan-zhang

@revan-zhang revan-zhang commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • python/requirements-optional.txt
⚠️ Warning
web3 6.20.4 requires requests, which is not installed.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Insecure Temporary File


Open with Devin

Note

Low Risk
Low risk dependency-only change: adds a requests>=2.33.0 pin in optional Python requirements to address a known vulnerability, with minimal impact beyond potential dependency resolution differences.

Overview
Pins requests to >=2.33.0 in python/requirements-optional.txt (even though it is transitive) to remediate a Snyk-reported vulnerability and ensure web3’s requests dependency is explicitly installed.

Written by Cursor Bugbot for commit e710e8b. This will update automatically on new commits. Configure here.

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-REQUESTS-15763443
@revan-zhang

revan-zhang commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Pillow
stellar-sdk>=4.0.0,<6.0.0
rlp>=1.1.0 ; python_version<'3.7'
requests>=2.33.0 # not directly required, pinned by Snyk to avoid a vulnerability

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests 2.33.0 requires Python 3.10+, breaking older versions

High Severity

The pinned requests>=2.33.0 requires Python 3.10+, but this project supports Python 3.6+ (per setup.py's python_requires=">=3.6"). The tox configuration runs full environments (which install requirements-optional.txt) on py36 through py39. On those Python versions, pip will fail to find any requests version satisfying >=2.33.0, breaking dependency resolution and the CI test matrix for four out of five tested Python versions. A python_version environment marker is needed to restrict this constraint to Python 3.10+.

Fix in Cursor Fix in Web

Pillow
stellar-sdk>=4.0.0,<6.0.0
rlp>=1.1.0 ; python_version<'3.7'
requests>=2.33.0 # not directly required, pinned by Snyk to avoid a vulnerability

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security fix applied to wrong file, ineffective for users

Medium Severity

The requests security pin is placed in requirements-optional.txt, but requests>=2.4.0 is already a direct dependency in requirements.txt (which feeds install_requires in setup.py). The requirements-optional.txt file is only consumed by the full tox test variant — it has no effect on end-user package installations. Users installing via pip install trezor or pip install -r requirements.txt will still resolve to potentially vulnerable requests versions. The vulnerability fix is effectively a no-op.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants