feat(kaspa): surface prev-tx-id mismatch under its own error code#841
Merged
Conversation
The device recomputes each spent input's previous-transaction id from the refTxs the caller supplies and refuses to sign when it doesn't match the outpoint. The kaspa REST source that refTxs are built from omits some consensus fields (lockTime, per-input sequence), so they get defaulted and can be wrong, which surfaced only as a generic RuntimeError carrying the firmware's raw text. Map that rejection to KaspaPrevTxIdMismatch (829) so the caller can act on it — rebuild the refTxs, or let the user confirm signing without on-device verification — instead of matching an English firmware string itself. The SDK deliberately does not retry without refTxs: dropping on-device input verification is the caller's decision to make, not a silent downgrade. Scoped to the streaming flow, the only path that sends refTxs; legacy blind signing never requests a previous transaction. Only the mismatch text gets the new code — user cancellation and every other device error pass through untouched.
wabicai
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device recomputes each spent input's previous-transaction id from the refTxs the caller supplies and refuses to sign when it doesn't match the outpoint. The kaspa REST source that refTxs are built from omits some consensus fields (lockTime, per-input sequence), so they get defaulted and can be wrong, which surfaced only as a generic RuntimeError carrying the firmware's raw text.
Map that rejection to KaspaPrevTxIdMismatch (829) so the caller can act on it — rebuild the refTxs, or let the user confirm signing without on-device verification — instead of matching an English firmware string itself. The SDK deliberately does not retry without refTxs: dropping on-device input verification is the caller's decision to make, not a silent downgrade.
Scoped to the streaming flow, the only path that sends refTxs; legacy blind signing never requests a previous transaction. Only the mismatch text gets the new code — user cancellation and every other device error pass through untouched.