Skip to content

[Snyk] Security upgrade requests from 2.25.1 to 2.33.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
revan-zhang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade requests from 2.25.1 to 2.33.0 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Pygments==2.9.0
pyparsing==2.4.7
pytz==2021.1
recommonmark==0.6.0
requests==2.25.1
requests==2.33.0

@cursor cursor Bot Mar 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incompatible pinned certifi version breaks dependency resolution

High Severity

Upgrading requests to 2.33.0 introduces a dependency conflict. requests==2.33.0 requires certifi>=2023.5.7, but certifi==2020.12.5 is pinned on line 4 of this same file. This will cause pip dependency resolution to fail, breaking the docs build. The charset_normalizer package (required >=2,<4 by requests 2.33.0) is also missing entirely from the pinned dependencies.

Fix in Cursor Fix in Web

@devin-ai-integration devin-ai-integration Bot Mar 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Dependency conflict: requests 2.33.0 requires certifi>=2023.5.7 but certifi is pinned to 2020.12.5

Upgrading requests from 2.25.1 to 2.33.0 without also upgrading certifi creates an unresolvable dependency conflict. requests==2.33.0 requires certifi>=2023.5.7, but docs/requirements.txt:4 pins certifi==2020.12.5. Running pip install -r docs/requirements.txt will fail with ResolutionImpossible, breaking the documentation build.

Prompt for agents 
In docs/requirements.txt, the requests upgrade to 2.33.0 requires updating other pinned dependencies to be compatible:

1. At line 4, update certifi from 2020.12.5 to at least 2023.5.7 (e.g. certifi==2025.1.31 or another recent version). requests 2.33.0 requires certifi>=2023.5.7.

2. Consider adding charset_normalizer (e.g. charset_normalizer==3.4.0) since requests 2.33.0 depends on it (it replaced chardet as the default character detection library starting with requests 2.26.0).

3. The chardet==4.0.0 pin at line 5 is no longer a required dependency of requests (it is only used with the optional use-chardet-on-py3 extra). Consider removing it or keeping it if other packages need it.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

six==1.16.0
snowballstemmer==2.1.0
Sphinx==4.0.1
Expand Down