Fix newsletter database secret ref deploy - #70
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NEWSLETTER_DATABASE_URLas a literal deployment env var.NEWSLETTER_DATABASE_URLas an optional KubernetessecretKeyReftoknowhere-secrets/newsletter-database-urlbefore rolling out the image.DATABASE_URL.Verification
pnpm test: passed, 13 test files and 65 testspnpm lint: passed with existing warningspnpm type-check: passedpnpm build: passed with build-validation environmentgit diff --check: passedManual browser checks: not applicable, deployment workflow and docs only.
Screenshots or Recordings
Not applicable for non-UI changes.
Deployment Notes
NEWSLETTER_DATABASE_URLis now delivered from optional Kubernetes Secret keyknowhere-secrets/newsletter-database-urlwhen present.DATABASE_URL.NEWSLETTER_DATABASE_URLentry before patching the optional secret ref.Checklist