fix(chat): honor document scope and block source-required finalize before search - #170
Merged
Merged
Conversation
- Removed unused types and functions related to KnowledgeReadResponse and KnowledgeGrepResponse from the knowhere-text and ledger modules. - Updated the knowhereToolText to handle chunk formatting with a new chunkPickStart parameter for better citation management. - Adjusted tests to reflect changes in response handling and ensure proper functionality with the updated code structure. This refactor enhances code clarity and maintains focus on relevant response types, improving overall maintainability.
…fore search Pass include/exclude document IDs through to Knowhere and keep finalize closed until a required document search has run. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
vitest run(813 passed, 14 skipped)tsc --noEmitMade with Cursor