fix: update tests for Effect-wrapped repository and reconcile dependencies - #68
Merged
Merged
Conversation
…ncies - Use expect.any(Function) for chat route repository assertions since chatTurnPersistence.createRepository() now wraps service methods - Return Promises from reconcile mock defaults so Effect.tryPromise doesn't fail on bare vi.fn() (which returns undefined) - Add 4th "parsing" arg to markSourceFailed expectation to match updated lifecycle function signature
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…age size - Remove obsolete search test from chunks-panel.test.ts (search was removed from the component in 9ee238e) - Switch workspace/client.test.ts from stubbing global fetch to mocking workspaceRouteClient (now uses Effect FetchHttpClient) - Update page size from 100 to 50 in workspace-shell test assertion (changed in 9ee238e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 test failures on
staging:chat/route-service.test.ts— Useexpect.any(Function)for repository assertions sincechatTurnPersistence.createRepository()now wraps service methods in adaptor functionsreconcile.test.ts— Return Promises fromloadReconcilemock defaults (vi.fn().mockResolvedValue(undefined)) soEffect.tryPromisedoesn't fail on barevi.fn()returningundefinedreconcile.test.ts— Add 4th"parsing"arg tomarkSourceFailedexpectation to match updated lifecycle signatureTest Plan
src/domains/chat/route-service.test.ts— 5/5 passsrc/domains/sources/reconcile.test.ts— 6/6 pass