Skip to content

Fix notebook desktop panel overflow on 13-inch viewports - #82

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/notebook-responsive-panels
May 25, 2026
Merged

suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/notebook-responsive-panels

Conversation

@suguanYang

@suguanYang suguanYang commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fit default desktop panel widths to the rendered workspace width while preserving minimum panel sizes and drag resizing.
  • Use the tabbed notebook layout below the desktop panel minimum width so narrow desktop/tablet widths such as 1099px do not show a clipped three-panel strip.
  • Add unit coverage and Playwright regressions for the 1280px desktop viewport and the 1099px below-minimum breakpoint.

Fixes Ontos-AI/knowhere#107

Tests

  • pnpm exec vitest run
  • pnpm run typecheck
  • pnpm run lint (passes with two existing unrelated warnings)
  • pnpm run build
  • Browser verification at 1280x832: desktop layout scrollWidth=1280, assistant panel right edge 1280
  • Browser verification at 1099x832: desktop layout hidden, document scrollWidth=1099, tabbed layout visible

@vercel

vercel Bot commented May 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
knowhere-notebook-staging Ready Ready Preview, Comment May 25, 2026 9:50am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
knowhere-notebook Ignored Ignored Preview May 25, 2026 9:50am

Request Review

@suguanYang
suguanYang force-pushed the fix/wangbinqi/notebook-responsive-panels branch from d43bb9d to 95e0c7e Compare May 25, 2026 09:49
@suguanYang
suguanYang merged commit d193688 into staging May 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant