Fix QStash webhook delivery state handling - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes QStash webhook delivery state handling for retry callbacks and lost terminal callbacks.
deliveringwhen the destination response is non-2xx, and only mark themdeliveredon 2xx responses.deliveringevents from QStash terminal delivery logs during the existing webhook recovery task.Fixes #24.
Verification
uv run --group lint ruff check apps/api/app/api/v1/routes/qstash_callbacks.py apps/api/tests/contract/test_qstash_callback_contract.py apps/worker/app/core/tasks/webhook_tasks.py apps/worker/tests/contract/test_webhook_recovery_contract.py packages/shared-python/shared/services/webhook/qstash_publisher.py packages/shared-python/shared/core/config/qstash.pyuv run --package knowhere-api-app --group dev pytest apps/api/tests/contract/test_qstash_callback_contract.py -quv run --package knowhere-worker-app --group dev pytest apps/worker/tests/contract/test_webhook_recovery_contract.py -q[503, 204], final event statusdelivered, and stale-delivering reconciliation result{"status":"success","recovered":0,"provider":"qstash","reconciled":1}.