fix(ecs): preserve validated staging worker CPU - #293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKER_CONCURRENCY=10Evidence
The one-vCPU topology is rejected by the measured worker health evidence. Two fixed 2-vCPU/4-GiB Fargate Spot tasks passed the accepted production-envelope replay through 100 jobs / 60 minutes.
Evidence: https://github.com/Ontos-AI/knowhere-api-infra/issues/22#issuecomment-5302077433
Main-branch source commit:
9937fc53Staging cherry-pick:
6e81538fVerification
uv run pytest deploy/ecs/test_render_task_definitions.py -q— 7 passeduv run --group lint ruff check deploy/ecs/test_render_task_definitions.py deploy/ecs/render_task_definitions.py— passedgit diff --check— passedA repository-wide
uv run pytest -qwas attempted on the main branch, but collection requires optional workspace dependencies and runtime configuration absent from the isolated worktree. The complete ECS deployment contract suite passes on both branches.Deployment note
Creating this PR does not deploy. Merging it into
stagingwill trigger the existing staging CD workflow, register a new task-definition revision at 2 vCPU / 4 GiB, preserve the service's current desired count, and roll the staging worker tasks.