Wait for worker health before staging API startup - #296
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RUNNINGandHEALTHYworker tasks before opening API admissionstartPeriodregressionEvidence
The first manual cold-start run failed safely: run 31894301138. Both revision-14 tasks entered
RUNNINGaround00:01:20 Asia/Shanghai, while the workflow checked health around00:01:33and found zero healthy tasks. The task definition has a 60-second container health-checkstartPeriod; both tasks subsequently becameHEALTHY. The API remained at desired count0.The AWS CLI
services-stablewaiter checks deployment count andrunningCount == desiredCount; it does not wait for container health. We therefore poll task health explicitly every 15 seconds after the service waiter completes.This is the bounded cold-start correction for Ontos-AI/knowhere-api-infra#30. It does not create resources or dispatch another AWS operation.
Verification
uv run pytest deploy/ecs -q— 15 passeduv run --group lint ruff check deploy/ecs/test_manage_staging_workflow.py deploy/ecs/render_task_definitions.py deploy/ecs/test_render_task_definitions.pyuv run --group typecheck pyright deploy/ecs/test_manage_staging_workflow.pygit diff --check