Wait for public staging API readiness - #297
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
502/503responses every ten seconds for up to five minutesEvidence
The corrected worker-health workflow reached API desired/running/pending
1/1/0but failed its immediate health request with HTTP502: run 31895113244. Shortly afterward, live target-group readback showed the API target ashealthy, and the same public/healthURL returned HTTP200. The API health endpoint itself is an in-process response and does not query Neon.The AWS CLI
services-stablewaiter verifies ECS deployment/running counts, not public load-balancer route readiness. We therefore poll the public endpoint within a hard deadline before declaring startup successful.This is the bounded API-readiness correction for Ontos-AI/knowhere-api-infra#30. It does not create resources or dispatch another AWS operation.
Verification
uv run pytest deploy/ecs -q— 16 passeduv run --group lint ruff check deploy/ecs/test_manage_staging_workflow.py deploy/ecs/render_task_definitions.py deploy/ecs/test_render_task_definitions.pyuv run --group typecheck pyright deploy/ecs/test_manage_staging_workflow.pygit diff --check