Skip to content

hotfix(retrieval): normalize psycopg2 database URL #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suguanYang merged 1 commit into from
Aug 28, 2026
+21 −1
Merged

hotfix(retrieval): normalize psycopg2 database URL #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions apps/api/tests/contract/test_retrieval_lazy_snapshot_quality_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
NamespaceKnowhereProvider,
SectionRow,
UnitRow,
knowhere_database_url,
)
from shared.services.retrieval.nav.nav_map_scores import (
build_score_units,
Expand Down Expand Up @@ -174,3 +175,18 @@ def test_streaming_scorer_preserves_duplicate_id_eager_semantics() -> None:
}

assert score_unit_stream_hybrid_all(lambda: rows, "alpha beta") == eager_scores


def test_native_chunk_store_strips_async_driver_from_database_url(
monkeypatch: Any,
) -> None:
monkeypatch.setenv(
"DATABASE_URL",
"postgresql+asyncpg://prod-user:prod-password@db.example/knowhere",
)
monkeypatch.delenv("KNOWHERE_DATABASE_URL", raising=False)

assert (
knowhere_database_url()
== "postgresql://prod-user:prod-password@db.example/knowhere"
)
6 changes: 5 additions & 1 deletion packages/shared-python/shared/services/retrieval/nav/nav_knowhere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@ def knowhere_database_url() -> str:
or str(os.environ.get("DATABASE_URL") or "").strip()
)
if configured:
return configured.replace("postgresql+asyncpg", "postgresql+psycopg2")
# ``ReadOnlyChunkStore`` uses psycopg2's native connector, which
# accepts libpq URLs but not SQLAlchemy's ``+driver`` suffix.
return configured.replace("postgresql+asyncpg://", "postgresql://", 1).replace(
"postgresql+psycopg2://", "postgresql://", 1
)
return _DEFAULT_DSN


Expand Down
Loading