fix: resolve CodeQL false positives in retrieval changes - #360
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revision,down_revision,branch_labels, anddepends_onglobals as unused.SQLAlchemyErrorand log the fallback context.rollback()implementation to the counting session test double.Why
Alembic consumes migration metadata by convention, so deleting those globals would break migration discovery. Exporting them via
__all__is a narrow, repository-local way to communicate that contract to CodeQL while preserving the check elsewhere.Verification
uv run ruff check ...uv run pyright ...pytest apps/api/tests/contract/test_retrieval_serving_manifest_contract.py apps/api/tests/contract/test_retrieval_manifest_cache_contract.pygit diff --checkThe separate classic-route scoring and serving-index projection findings require behavior-level design/contract changes and are intentionally not mixed into this tooling/fallback cleanup PR.