fix: resolve CodeQL redundant comparison and empty except warnings - #50
Merged
Merged
Conversation
suguanYang
force-pushed
the
fix/wangbinqi/codeql-issues
branch
from
May 13, 2026 10:23
292e178 to
eca7a52
Compare
asset_url was removed from the regular document chunk API responses in PR #46. The contract test now uses file_path instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 CodeQL warnings flagged on PR #49:
agent_navigate.py:608— Removed redundantdepth > scope_depthfromis_descendantassignment (guaranteed by earlierdepth <= scope_depth+continue)agent_navigate.py:633— Removed redundantif depth > scope_depth:guard insideelsebranch (same reason)token_estimate.py:27— Added comment to emptyexceptclause explaining intentional fallback tocl100k_basedefault encoding