Skip to content

Fix agentic VLM image input selection - #93

Merged
suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/retrieval-vlm-table-artifacts
May 19, 2026
Merged

suguanYang merged 1 commit into
stagingfrom
fix/wangbinqi/retrieval-vlm-table-artifacts

Conversation

@suguanYang

@suguanYang suguanYang commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restrict agentic retrieval VLM image_url inputs to chunks whose type is actually image
  • Keep image + table media collection unchanged for evidence rendering and table artifact hydration
  • Add retrieval API contract coverage proving table artifacts remain present as evidence references but do not invoke VLM

Closes #92.

Verification

  • uv run pytest apps/api/tests/contract/test_retrieval_contract.py -k table_artifacts_to_vlm -q
  • uv run pytest apps/api/tests/contract/test_retrieval_contract.py -q
  • uv run ruff check apps/api/tests/contract/test_retrieval_contract.py packages/shared-python/shared/services/retrieval/agentic/evidence/builder.py packages/shared-python/shared/services/retrieval/agentic/orchestrator.py
  • uv run pyright
  • uv run ruff check
  • git diff --check
  • git diff --cached --check
  • codex review --uncommitted --title "Retrieval VLM table artifact contract coverage"

@suguanYang
suguanYang force-pushed the fix/wangbinqi/retrieval-vlm-table-artifacts branch from b229981 to 3168d32 Compare May 19, 2026 03:07
@suguanYang
suguanYang force-pushed the fix/wangbinqi/retrieval-vlm-table-artifacts branch from 3168d32 to b73ea0d Compare May 19, 2026 03:40
@suguanYang
suguanYang merged commit 4cbf388 into staging May 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant