Skip to content

Fix MinerU upload mode flag - #94

Merged
suguanYang merged 4 commits into
stagingfrom
fix/wangbinqi/mineru-upload-mode
May 19, 2026
Merged

suguanYang merged 4 commits into
stagingfrom
fix/wangbinqi/mineru-upload-mode

Conversation

@suguanYang

@suguanYang suguanYang commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #83.

  • Add MINERU_UPLOAD_MODE_ENABLED as the explicit MinerU direct-upload mode flag, defaulting to false.
  • Stop using ENVIRONMENT to decide MinerU URL mode; when upload mode is disabled and a reusable s3_key exists, the worker uses S3 URL mode.
  • Drop the old FORCE_MINERU_UPLOAD_ENABLED configuration path instead of maintaining a legacy alias.
  • Document that LocalStack/private storage URLs should set MINERU_UPLOAD_MODE_ENABLED=true to force direct upload.
  • Leave MinerU timeout behavior unchanged.

Verification

  • uv run pytest apps/worker/tests/contract -q
  • uv run ruff check
  • uv run pyright
  • git diff --check
  • git diff --cached --check

@suguanYang
suguanYang merged commit 72b4d01 into staging May 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant