fix: make PDF page limit configurable - #98
Merged
Merged
Conversation
suguanYang
force-pushed
the
fix/wangbinqi/configurable-pdf-page-limit
branch
from
May 19, 2026 08:40
98d687e to
27a3170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_PDF_PAGE_LIMIT, defaulting to the existing 600-page behavior.MAX_PDF_PAGE_LIMIT=600in API and worker env examples.INVALID_ARGUMENTbefore result packaging runs.Verification
uv run pytest apps/worker/tests/contract/test_parse_task_contract.py::test_should_reject_pdf_when_page_count_exceeds_configured_limit -quv run pytest apps/worker/tests/contract/test_parse_task_contract.py -quv run pytest apps/worker/tests/contract -quv run ruff checkuv run pyrightgit diff --checkMAX_PDF_PAGE_LIMIT=123 ... uv run pythonconfig smoke confirmed env override is read as123codex review --uncommitted --title "Make PDF page limit configurable"